Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4483 PS10, Line 4483: // last synced event id for the table. To ensure that subsequent method calls > I was actually wondering if it would be better to error here and let the ev Yeah, we should throw an exception here to abort the optimization and use the latest HMS event id to wait for. So we can ensure the correctness. Done in the new patch set. We won't leave the metadata in a bad state here since if the view failed to be loaded by recoverable errors (e.g. lost HMS connections immittently), it will be reloaded when it's used again (IMPALA-13120). If the cause is a non-recoverable error, it's OK to keep it as loaded IncompleteTable to show the casue. http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4523 PS10, Line 4523: } > Same concern as above. Done -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 12 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 09:16:25 +0000 Gerrit-HasComments: Yes
