Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20169
to look at the new patch set (#18).
Change subject: IMPALA-11980 (part 1): Put all thrift-generated python code
into the impala_thrift_gen package
......................................................................
IMPALA-11980 (part 1): Put all thrift-generated python code into the
impala_thrift_gen package
This puts all of the thrift-generated python code into the
impala_thrift_gen package. This is similar to what Impyla
does for its thrift-generated python code, except that it
uses the impala_thrift_gen package rather than impala._thrift_gen.
This is a preparatory patch for fixing the absolute import
issues.
This patches all of the thrift files to add the python namespace.
This has code to apply the patching to the thirdparty thrift
files (hive_metastore.thrift, fb303.thrift) to do the same.
Putting all the generated python into a package makes it easier
to understand where the imports are getting code. When the
subsequent change rearranges the shell code, the thrift generated
code can stay in a separate directory.
This uses isort to sort the imports for the affected Python files
with the provided .isort.cfg file. This also adds an impala-isort
shell script to make it easy to run.
Testing:
- Ran a core job
Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0
---
A .isort.cfg
A bin/cmake_aux/add_thrift_python_namespace.sh
A bin/impala-isort
M common/thrift/.gitignore
M common/thrift/BackendGflags.thrift
M common/thrift/CMakeLists.txt
M common/thrift/CatalogInternalService.thrift
M common/thrift/CatalogObjects.thrift
M common/thrift/CatalogService.thrift
M common/thrift/Data.thrift
M common/thrift/DataSinks.thrift
M common/thrift/Descriptors.thrift
M common/thrift/ExecStats.thrift
M common/thrift/Exprs.thrift
M common/thrift/ExternalDataSource.thrift
M common/thrift/Frontend.thrift
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/JniCatalog.thrift
M common/thrift/LineageGraph.thrift
M common/thrift/Logging.thrift
M common/thrift/Metrics.thrift
M common/thrift/NetworkTest.thrift
M common/thrift/Partitions.thrift
M common/thrift/PlanNodes.thrift
M common/thrift/Planner.thrift
M common/thrift/Query.thrift
M common/thrift/ResourceProfile.thrift
M common/thrift/Results.thrift
M common/thrift/RuntimeProfile.thrift
M common/thrift/SqlConstraints.thrift
M common/thrift/StatestoreService.thrift
M common/thrift/Status.thrift
M common/thrift/SystemTables.thrift
M common/thrift/Types.thrift
M common/thrift/Zip.thrift
M common/thrift/beeswax.thrift
M common/thrift/generate_error_codes.py
M common/thrift/generate_metrics.py
M common/thrift/hive-1-api/TCLIService.thrift
M common/thrift/parquet.thrift
M infra/python/deps/py3-requirements.txt
M lib/python/impala_py_lib/profiles.py
M shell/exec_summary.py
M shell/impala_client.py
M shell/value_converter.py
M testdata/bin/wait-for-hiveserver2.py
M testdata/bin/wait-for-metastore.py
M tests/authorization/test_authorization.py
M tests/authorization/test_authorized_proxy.py
M tests/beeswax/impala_beeswax.py
M tests/catalog_service/test_catalog_service_client.py
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_delegation.py
M tests/custom_cluster/test_event_processing_error.py
M tests/custom_cluster/test_events_custom_configs.py
M tests/custom_cluster/test_hs2.py
M tests/custom_cluster/test_metastore_service.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_query_retries.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_statestored_ha.py
M tests/custom_cluster/test_workload_mgmt_init.py
M tests/custom_cluster/test_workload_mgmt_sql_details.py
M tests/hs2/hs2_test_suite.py
M tests/hs2/test_fetch.py
M tests/hs2/test_fetch_first.py
M tests/hs2/test_fetch_timeout.py
M tests/hs2/test_hs2.py
M tests/hs2/test_json_endpoints.py
M tests/metadata/test_compute_stats.py
M tests/query_test/test_acid.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_iceberg.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_observability.py
M tests/query_test/test_parquet_bloom_filter.py
M tests/query_test/test_parquet_page_index.py
M tests/query_test/test_query_opts.py
M tests/query_test/test_scanners.py
M tests/statestore/test_statestore.py
M tests/util/acid_txn.py
M tests/util/event_processor_utils.py
M tests/util/get_parquet_metadata.py
M tests/util/parse_util.py
M tests/util/workload_management.py
90 files changed, 589 insertions(+), 321 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/20169/18
--
To view, visit http://gerrit.cloudera.org:8080/20169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0
Gerrit-Change-Number: 20169
Gerrit-PatchSet: 18
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
