Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: IMPALA-11980 (part 1): Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 18: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20169/18/bin/cmake_aux/add_thrift_python_namespace.sh File bin/cmake_aux/add_thrift_python_namespace.sh: http://gerrit.cloudera.org:8080/#/c/20169/18/bin/cmake_aux/add_thrift_python_namespace.sh@55 PS18, Line 55: cat $THRIFT_FILE_IN | grep -v "namespace py" | awk "$ADD_NAMESPACE_PY" > $THRIFT_FILE_OUT nit: the 'namespace py' match seems a bit general, maybe force it to be the beginning of the line grep -v "^namespace py " Although I am having trouble coming up with a way this could appear in a Thrift file otherwise. Maybe as a comment (in which case it doesn't really matter if we omit it). -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 18 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 22:46:11 +0000 Gerrit-HasComments: Yes
