Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: IMPALA-11980 (part 1): Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 18: Code-Review+1 (1 comment) Thank you for taking care of this, Joe! The sooner we merge this, the better. I can give this +2 if nobody else has an issue. http://gerrit.cloudera.org:8080/#/c/20169/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20169/18//COMMIT_MSG@25 PS18, Line 25: This uses isort to sort the imports for the affected Python files : with the provided .isort.cfg file. This also adds an impala-isort : shell script to make it easy to run. nit: Lets follow up with enforcing it at critique-gerrit-review.py later after this patch merged. -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 18 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 22:35:08 +0000 Gerrit-HasComments: Yes
