Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/22062/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22062/20//COMMIT_MSG@12 PS20, Line 12: The following counters are added: > Added RowBatchMemPoolAllocDuration and RowBatchMemPoolAllocBytes. I strange pattern I see here is that we have frees but no allocs: - RowBatchMemPoolAllocBytes: 0 (Number of samples: 0) - RowBatchMemPoolAllocDuration: 0.000ns (Number of samples: 0) - RowBatchMemPoolFreeBytes: (Avg: 489.71 KB (501463) ; Min: 4.00 KB (4096) ; Max: 512.00 KB (524288) ; Sum: 66.00 MB (69201920) ; Number of samples: 138) - RowBatchMemPoolFreeDuration: (Avg: 18.768us ; Min: 108.000ns ; Max: 92.245us ; Sum: 2.590ms ; Number of samples: 138) using a SELECT (UNION ALL) ORDER BY LIMIT query that forces materialization. That's not wild, other locations allocate more than they free, but I expected to see some allocation from materialized strings. Specific setup was create table iceberg_small_page stored by iceberg as select *, repeat(l_comment, 10) from tpch.lineitem; select l_partkey, _c1 from (select l_partkey, _c1, l_commitdate from iceberg_large_page where length(l_shipdate) > 1 union all select l_partkey+1, _c1, l_shipdate from iceberg_large_page where length(l_commitdate) > 1) x order by l_partkey limit 100000 -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 21 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 04:03:57 +0000 Gerrit-HasComments: Yes
