Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 19: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22062/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22062/18//COMMIT_MSG@17 PS18, Line 17: - ScratchBatchMemAllocDuration : - ScratchBatchMemFreeDuration : - ScratchBatchMemAllocBytes > > Why there is no ScratchBatchMemFreeBytes when there is ParquetDataPagePoo Ack http://gerrit.cloudera.org:8080/#/c/22062/18/be/src/exec/hdfs-columnar-scanner.cc File be/src/exec/hdfs-columnar-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22062/18/be/src/exec/hdfs-columnar-scanner.cc@338 PS18, Line 338: } : > SummaryStatsCounter::SetStats() and SummaryStatsCounter::Merge() requires h Right. The way it is now, counters will only show up after the scanner thread (1 per scan range?) finished. Maybe it is OK if it updates frequent enough. -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 19 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 23:47:16 +0000 Gerrit-HasComments: Yes
