Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 21: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/hdfs-scanner.h@170 PS21, Line 170: virtual void CloseInternal(); It's a little weird this is a public interface, I would have made it protected. Based on the function comment, it seems like the right place to augment scanner shutdown behavior though. http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/parquet/hdfs-parquet-scanner.cc@75 PS21, Line 75: "Not part of DecompressionTime."); Can we say where they are tracked? Do they show up in ScannerIoWaitTime or ScannerThreadsSysTime? http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/scratch-tuple-batch.h File be/src/exec/scratch-tuple-batch.h: http://gerrit.cloudera.org:8080/#/c/22062/21/be/src/exec/scratch-tuple-batch.h@221 PS21, Line 221: Tuple* GetTuple(int idx) const { Any reason you changed the name? Seems like an arbitrary change. -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 21 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 21:34:31 +0000 Gerrit-HasComments: Yes
