Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 2): Implement in-place reset for CatalogD ...................................................................... Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2408 PS15, Line 2408: .forEachOrdered(resettingDbs_::add); > Oh, my bad. That should handle the case. Done http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2425 PS15, Line 2425: oldDbN > Should be 'oldDbName'. Good catch, Thanks! http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_local_catalog.py@111 PS15, Line 111: self.execute_query_expect_success(client1, "invalidate metadata", query_options) : err = self.execute_query_expect_failure(client2, "describe database %s" % new_db) : assert 'Database does not exist' in str(err) > It's due to a wrong db name is used when removing the non-existing db: http Thanks! Reverted. http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py@388 PS15, Line 388: .format(frequency_ms=(UPDATE_FREQUENCY_S * 1000))) : def test_restart_local_catalogd_twice(self, unique_database): : self.run_restart_catalogd_twice(unique_database, False) : : def run_restart_catalogd_twice(self, unique_database, is_legacy_mode): : tbl_name = unique_database + ".join_aa" : first_impalad = self.cluster.get_first_impalad() : monitor = CatalogChangeMonitor(first_impalad, is_legacy_mode, self.UPDATE_FREQUENCY_S) : : self.cluster.catalogd.restart() : monitor.wait_for_catalog_change() : : def execute_query_async(): : query = "create table {}(id int)".format(tbl_name) : self.execute_query(query) : > Need to contain this into a class for reuse in other place. Done http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py@416 PS15, Line 416: @pytest.mark.execute_serially : @CustomClusterTestSuite.with_args( > This is time sensitive and may either fail or success depending on the spee Done -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 21:48:26 +0000 Gerrit-HasComments: Yes
