Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 2): Implement in-place reset for CatalogD ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py@388 PS15, Line 388: def catalogd_service_id_changed(): : old_id = catalogd_service_ids[-1] : new_id = first_impalad.service.get_metric_value('catalog.curr-serviceid') : changed = (old_id != new_id) : if changed: : catalogd_service_ids.append(new_id) : return changed : : def wait_for_usable_catalog(): : # wait for catalog service id to change. : retry(catalogd_service_id_changed, 60, 1, 1) : if is_legacy_mode: : # IMPALA-13850: CatalogD in legacy mode may broadcast its availability before : # fully loading all databases. Wait for another UPDATE_FREQUENCY_S to ensure : # coordinator heard about full IMPALA_CATALOG_TOPIC update. : sleep(self.UPDATE_FREQUENCY_S) Need to contain this into a class for reuse in other place. http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_restart_services.py@416 PS15, Line 416: # Executing query will fail before coordinator notice changes in catalog service id. : self.execute_query_expect_failure(self.client, "describe {}".format(tbl_name)) This is time sensitive and may either fail or success depending on the speed of first topic update arrival. It is better to remove it. -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 21:45:19 +0000 Gerrit-HasComments: Yes
