Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 2): Implement in-place reset for CatalogD ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2408 PS15, Line 2408: .forEachOrdered(resettingDbs_::add); > non-existing dbs is removed by polling oldDbNames in L2421 and L2473. Oh, my bad. That should handle the case. http://gerrit.cloudera.org:8080/#/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2425 PS15, Line 2425: dbName Should be 'oldDbName'. http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/22640/15/tests/custom_cluster/test_local_catalog.py@111 PS15, Line 111: # Make sure to wait for HMS events for the next query. : query_options["sync_hms_events_wait_time_s"] = 60 : query_options["sync_hms_events_strict_mode"] = True > Test that use_local_catalog=True failed assertion in L115 (no failure happe It's due to a wrong db name is used when removing the non-existing db: https://gerrit.cloudera.org/c/22640/15/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#2425 -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 11 Apr 2025 10:16:27 +0000 Gerrit-HasComments: Yes
