Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/22062/17/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/22062/17/be/src/util/runtime-profile.cc@2590 PS17, Line 2590: // Don't print the sum if it's meaningless. > Is Sum relevant to all stats where this is used? If not, Sum should be an o Right, it's meaningless for speeds like NetworkThroughput, e.g. - NetworkThroughput: (Avg: 365.91 MB/sec ; Min: 7.02 MB/sec ; Max: 913.02 MB/sec ; Number of samples: 120) Changed to not print the sum for speeds and percentages. Sum of some stats using unit BYTES might still be meanlingless, e.g. memory usage. But it seems we don't have such SummaryStatsCounter yet. Most of them use SamplingTimeSeriesCounter. If we do have such counters in the future, we can add an optional boolean argument to the constructor of SummaryStatsCounter to indicate if sum is valid. -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 18 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:24:32 +0000 Gerrit-HasComments: Yes
