Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22666 )
Change subject: IMPALA-13882: Fix Iceberg v2 deletes with tuple caching ...................................................................... IMPALA-13882: Fix Iceberg v2 deletes with tuple caching A variety of Iceberg statements (including v2 deletes) rely on getting information from the scan node child of the delete node. Since tuple caching can insert a TupleCacheNode above that scan, the logic is currently failing, because it doesn't know how to bypass the TupleCacheNode and get to the scan node below. This modifies the logic in multiple places to detect a TupleCacheNode and go past it to the get the scan node below it. Testing: - Added a basic Iceberg test with v2 deletes for the frontend test and custom cluster test Change-Id: I162e738c4e4449a536701a740272aaac56ce8fd8 Reviewed-on: http://gerrit.cloudera.org:8080/22666 Reviewed-by: Kurt Deschler <kdesc...@cloudera.com> Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/exec-node.h M be/src/exec/iceberg-delete-builder.cc M be/src/runtime/fragment-state.cc M fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java M tests/custom_cluster/test_tuple_cache.py 6 files changed, 60 insertions(+), 6 deletions(-) Approvals: Kurt Deschler: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I162e738c4e4449a536701a740272aaac56ce8fd8 Gerrit-Change-Number: 22666 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
