Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22666 )
Change subject: IMPALA-13882: Fix Iceberg v2 deletes with tuple caching ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc@131 PS2, Line 131: // Tuple caching can place a TupleCacheNode above the scan node. Look past I think this would make sense as a helper that could also be used in fragment-state.cc, something like delete_scan_node = current->GetScanNode(0); http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc@138 PS2, Line 138: if (delete_scan_node->tnode_->node_type != TPlanNodeType::HDFS_SCAN_NODE) { Should this be a DCHECK? I think it would only happen if we've done something wrong in our code. -- To view, visit http://gerrit.cloudera.org:8080/22666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I162e738c4e4449a536701a740272aaac56ce8fd8 Gerrit-Change-Number: 22666 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Mar 2025 22:26:15 +0000 Gerrit-HasComments: Yes
