Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22666 )
Change subject: IMPALA-13882: Fix Iceberg v2 deletes with tuple caching ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc@131 PS2, Line 131: // a TupleCacheNode to get to the scan node. > I turned this into a static helper function on PlanNode to look past a sing Ack http://gerrit.cloudera.org:8080/#/c/22666/2/be/src/exec/iceberg-delete-builder.cc@138 PS2, Line 138: while (!q.empty()) q.pop(); > Changed this to a DCHECK. I think the code in fragment-state.cc would fail Done http://gerrit.cloudera.org:8080/#/c/22666/3/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/22666/3/be/src/exec/iceberg-delete-builder.cc@307 PS3, Line 307: if (file_path->Ptr() == prev_file_path.Ptr() || *file_path == prev_file_path) { What led to this change? -- To view, visit http://gerrit.cloudera.org:8080/22666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I162e738c4e4449a536701a740272aaac56ce8fd8 Gerrit-Change-Number: 22666 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 22:35:09 +0000 Gerrit-HasComments: Yes
