Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22661 )
Change subject: IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ ...................................................................... IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ Currently, tuple cache correctness verification does a fast check, and returns an error if file sizes are different. This patch allows a slow check when file sizes differ. Because the slow check may provide a clearer error message and help prevent false mismatches when identical rows appear in a different order, which may lead to size differences. Updated TupleTextFileUtilTest for this change. Also fixes argument order in VerifyRows() to correct misleading log output. The previous order was incorrect, causing the log to show the wrong one as the reference file. Tests: Passed core tests. Manually verified that when file sizes differ, the query proceeds to the slow check after this change. Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a Reviewed-on: http://gerrit.cloudera.org:8080/22661 Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Reviewed-by: Kurt Deschler <kdesc...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/tuple-cache-node.cc M be/src/exec/tuple-text-file-util-test.cc M be/src/exec/tuple-text-file-util.cc 3 files changed, 27 insertions(+), 20 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Kurt Deschler: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a Gerrit-Change-Number: 22661 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
