Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22661 )
Change subject: IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22661/6/be/src/exec/tuple-text-file-util.cc File be/src/exec/tuple-text-file-util.cc: http://gerrit.cloudera.org:8080/#/c/22661/6/be/src/exec/tuple-text-file-util.cc@158 PS6, Line 158: // If the sizes are different, proceed with a slower check by leaving passed false. Is file size an adequate check here? Please comment on assumptions here. I could understand if file data is delimited text and not padded that size alone could be adequate. But even then, changes could go undetected unless value widths change. -- To view, visit http://gerrit.cloudera.org:8080/22661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a Gerrit-Change-Number: 22661 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 14:35:32 +0000 Gerrit-HasComments: Yes
