Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22661 )
Change subject: IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22661/6/be/src/exec/tuple-text-file-util.cc File be/src/exec/tuple-text-file-util.cc: http://gerrit.cloudera.org:8080/#/c/22661/6/be/src/exec/tuple-text-file-util.cc@158 PS6, Line 158: // Files are supposed to be written in tuple-text-file-writer.cc, and are plain > Is there any value to a "fast path" then? It sounds like in both cases we c If all are identical (size and order), the fast path is much faster, which is the case in most scenarios. The slow path, on the other hand, needs to create a map for comparison, making it slower and requiring much more memory. -- To view, visit http://gerrit.cloudera.org:8080/22661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a Gerrit-Change-Number: 22661 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 17:32:36 +0000 Gerrit-HasComments: Yes
