Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/22062/16/be/src/exec/hdfs-columnar-scanner.cc File be/src/exec/hdfs-columnar-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22062/16/be/src/exec/hdfs-columnar-scanner.cc@71 PS16, Line 71: PROFILE_DEFINE_SUMMARY_STATS_TIMER(ScratchBatchMemAllocDuration, DEBUG, : "Stats of time spent in malloc() used by MemPools of the scratch batch."); : PROFILE_DEFINE_SUMMARY_STATS_TIMER(ScratchBatchMemFreeDuration, DEBUG, : "Stats of time spent in free() used by MemPools of the scratch batch."); : PROFILE_DEFINE_SUMMARY_STATS_COUNTER(ScratchBatchMemAllocBytes, DEBUG, TUnit::BYTES, : "Stats of bytes allocated by MemPools of the scratch batch."); : PROFILE_DEFINE_TIMER(MaterializeCollectionGetMemTime, UNSTABLE, "Wall clock time spent " : "getting/allocating collection memory. Includes the memcpy duration when doubling " : "the tuple buffer."); > Thank you for doing it this way. IMO, we should continue IMPALA-7550 work w Agree on this. I compromised with the code style so tried to make the new codes fit into existing codes. But it seems the profile docs are more important to our product. Done this for all new counters except MinorPageFaults and MajorPageFaults. Their names have a customized prefix so can't define them this way. https://gerrit.cloudera.org/c/22062/16/be/src/util/runtime-profile.cc#1219 -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 17 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 07 Apr 2025 09:28:48 +0000 Gerrit-HasComments: Yes
