Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 39: (9 comments) I've split out cancelling catalog operations as a follow-on patch, as that had significant discussion and it was getting hard to track across such a large patch. http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/21803/24/be/src/service/fe-support.cc@592 PS24, Line 592: if (!request.__isset.header) { > I haven't seen a case where it's needed. Done http://gerrit.cloudera.org:8080/#/c/21803/16/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/16/be/src/service/impala-hs2-server.cc@1113 PS16, Line 1113: // Make query id available to the following HS2_RETURN_IF_ERROR(). > Oh, I see this is printed at the end. Done http://gerrit.cloudera.org:8080/#/c/21803/29/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/29/be/src/service/impala-server.cc@a2942 PS29, Line 2942: : : : : : : : : : > ExpireQuery's 3rd argument is whether to also call UnregisterQuery. In this Done http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21803/24/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3825 PS24, Line 3825: ep.start(ep.getLastSyncedEventId()); > You mean improve the error message we produce? It will include the original Done http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@195 PS12, Line 195: } > I experimented with local-catalog mode and didn't really get the query thre This is implemented, I'm going to move it to a follow-up commit to make it easier to track different review threads. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@576 PS29, Line 576: if (inCache != f) { > That's fair. Sometimes admins will love this "feature". Maybe it's unsane t Finish reviewing in the follow-on patch. http://gerrit.cloudera.org:8080/#/c/21803/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2048 PS1, Line 2048: // Timeline of important events in the planning process, used for debugging > Actually InterruptedException is always caught before this, so it's either Done http://gerrit.cloudera.org:8080/#/c/21803/9/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/9/tests/webserver/test_web_pages.py@1028 PS9, Line 1028: > They would change if we switched to local catalog mode as the default. I co Done http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py@1085 PS12, Line 1085: "'anonymous' at" in response.text > This got even more involved, but I've addressed these cases. Still needs ad Done -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 39 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 21:22:40 +0000 Gerrit-HasComments: Yes
