Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 41: (4 comments) Working on addressing the other comments. http://gerrit.cloudera.org:8080/#/c/21803/41/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21803/41/be/src/service/client-request-state.cc@256 PS41, Line 256: RETURN_IF_CANCELLED(this); > In the ExecQueryOrDmlRequest function, RETURN_IF_CANCELLED happens after th Those both seem reasonable. Moving MarkActive later might delay execution if any of the profile update calls take significant time, but they generally shouldn't. http://gerrit.cloudera.org:8080/#/c/21803/41/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/41/fe/src/main/java/org/apache/impala/service/Canceller.java@49 PS41, Line 49: private static Set<Thread> cancelledThreads_ = ConcurrentHashMap.newKeySet(); > It may be possible to eliminate this class and use a ThreadLocal in Fronten cancel() needs to be able to modify this value from a different thread than the execution thread. http://gerrit.cloudera.org:8080/#/c/21803/41/fe/src/main/java/org/apache/impala/service/Canceller.java@132 PS41, Line 132: public static void lock(Lock lock) throws UserCancelledException { > Is this method used? Probably not, I'll see about moving it to the following patch. http://gerrit.cloudera.org:8080/#/c/21803/41/fe/src/main/java/org/apache/impala/service/Canceller.java@146 PS41, Line 146: public static <V extends Object> V getUninterruptibly(Future<V> future) > Is this method used? Probably not, I'll see about moving it to the following patch. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 41 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 21:28:48 +0000 Gerrit-HasComments: Yes
