Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: WIP IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 12: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22424/12/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/12/shell/impala_shell.py@1017 PS12, Line 1017: \ flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22424/12/shell/impala_shell.py@1037 PS12, Line 1037: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22424/12/shell/impala_shell.py@1037 PS12, Line 1037: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py@20 PS12, Line 20: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py@26 PS12, Line 26: from tests.util.mock_oauth_server import MockOAuthServer flake8: F401 'tests.util.mock_oauth_server.MockOAuthServer' imported but unused http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py@207 PS12, Line 207: b flake8: F841 local variable 'before_rpc_count' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py@247 PS12, Line 247: b flake8: F841 local variable 'before_rpc_count' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22424/12/tests/custom_cluster/test_shell_jwt_auth.py@258 PS12, Line 258: r flake8: F841 local variable 'result' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 12 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 00:12:01 +0000 Gerrit-HasComments: Yes
