Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: WIP IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 10: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py File tests/util/mock_http_server.py: http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@25 PS10, Line 25: class MockHTTPRequestHandler(http.server.BaseHTTPRequestHandler): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@28 PS10, Line 28: J flake8: F821 undefined name 'JWKS_JWTS_DIR' http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@41 PS10, Line 41: p flake8: F841 local variable 'post_data' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@56 PS10, Line 56: class MockHTTPServer: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@72 PS10, Line 72: w flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22424/10/tests/util/mock_http_server.py@73 PS10, Line 73: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 21:50:59 +0000 Gerrit-HasComments: Yes
