Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: WIP IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 11: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py File tests/util/mock_oauth_server.py: http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@22 PS11, Line 22: import os flake8: F401 'os' imported but unused http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@24 PS11, Line 24: import sys flake8: F401 'sys' imported but unused http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@27 PS11, Line 27: class MockHTTPRequestHandler(http.server.BaseHTTPRequestHandler): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@40 PS11, Line 40: p flake8: F841 local variable 'post_data' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@55 PS11, Line 55: class MockOAuthServer: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22424/11/tests/util/mock_oauth_server.py@66 PS11, Line 66: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Sat, 29 Mar 2025 03:03:47 +0000 Gerrit-HasComments: Yes
