Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22371 )
Change subject: IMPALA-13660: Support caching broadcast hash joins ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/nested-loop-join-node.cc File be/src/exec/nested-loop-join-node.cc: http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/nested-loop-join-node.cc@180 PS6, Line 180: builder_ = dynamic_cast<NljBuilder*>(separate_builder); nit: might be worth a comment and/or DCHECK if we would only ever expect an NljBuilder, or if you're relying on dynamic_cast returning nullptr in other cases. http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/nested-loop-join-node.cc@187 PS6, Line 187: if (!separate_build || waited_for_build_) { I think this covers all the possible boolean alternatives to the else-if clause. So might be clearer to do if (separate_build && !waited_for_build_) { CloseBeforeProbe } else { CloseFromProbe } Double check me on that though. http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/partitioned-hash-join-node.cc@312 PS6, Line 312: builder_ = dynamic_cast<PhjBuilder*>(separate_builder); Same comment as https://gerrit.cloudera.org/c/22371/6/be/src/exec/nested-loop-join-node.cc#180. http://gerrit.cloudera.org:8080/#/c/22371/6/be/src/exec/partitioned-hash-join-node.cc@325 PS6, Line 325: } else if (separate_build && !waited_for_build_) { Same comment as https://gerrit.cloudera.org/c/22371/6/be/src/exec/nested-loop-join-node.cc#187. http://gerrit.cloudera.org:8080/#/c/22371/6/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/22371/6/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1410 PS6, Line 1410: * not be beneficial. I think it'd be useful to specifically call out that this is useful because higher level nodes might still place a tuple cache node. Presumably this is the same way we'd add Union support. -- To view, visit http://gerrit.cloudera.org:8080/22371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61462702b43175c593b34e8c3a14b9cfe85c29e Gerrit-Change-Number: 22371 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 00:12:32 +0000 Gerrit-HasComments: Yes
