Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22371 )
Change subject: IMPALA-13660: Support caching broadcast hash joins ...................................................................... Patch Set 5: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22371/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/22371/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@155 PS5, Line 155: verifyNIdenticalCacheKeys(rightJoinAgg, rightJoinAgg, 2, /* isDistributedPlan */ true); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22371/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@162 PS5, Line 162: verifyNIdenticalCacheKeys(innerJoinAgg, innerJoinAgg, 2, /* isDistributedPlan */ true); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22371/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@354 PS5, Line 354: // Different predicates on the join node makes the cache keys different, but it doesn't line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22371/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@416 PS5, Line 416: protected List<PlanNode> getCacheEligibleNodes(String query, boolean isDistributedPlan) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61462702b43175c593b34e8c3a14b9cfe85c29e Gerrit-Change-Number: 22371 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 19:18:32 +0000 Gerrit-HasComments: Yes
