Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22371 )
Change subject: IMPALA-13660: Support caching broadcast hash joins ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/join-builder.h File be/src/exec/join-builder.h: http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/join-builder.h@145 PS4, Line 145: /// This is called from BlockingJoinNode to signal that the node won't even the > incomplete: "won't even the"? Done http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/join-builder.cc File be/src/exec/join-builder.cc: http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/join-builder.cc@83 PS4, Line 83: VLOG(3) << "JoinBuilder (id=" << join_node_id_ << ")" > Add something to this message that makes it clear that the probe was skippe Changed "closed from finstance" to "closed before probe from finstance" I did a corresponding change to CloseFromProbe to say "closed from probe from finstance" http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/22371/4/be/src/exec/tuple-cache-node.cc@146 PS4, Line 146: child(0)->Close(state); > Does it matter that the child may not have been opened yet? Moved this to GetNext(), as we still try to recover from errors at that point. Close() is required to work even if the child is never opened. For example, Prepare() can fail and Close() still gets called. -- To view, visit http://gerrit.cloudera.org:8080/22371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61462702b43175c593b34e8c3a14b9cfe85c29e Gerrit-Change-Number: 22371 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 20:12:46 +0000 Gerrit-HasComments: Yes
