Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22652 )
Change subject: IMPALA-13881: Fix Workload Management Statement Expression Limit Exceeded Errors ...................................................................... IMPALA-13881: Fix Workload Management Statement Expression Limit Exceeded Errors The workload management code calculates the needed statement expression limit by multiplying the number of columns in the workload management completed queries table by the number of rows being inserted. This calculation was added in case the default_query_options startup flag sets the default value of the statement_expression_limit query option to a very low value. In practice, the calculation has been wrong causing workload management insert DMLs to fail with: "AnalysisException: Exceeded the statement expression limit (1024)". This commit adds a new hidden startup flag query_log_expression_limit to set the value of the statement_expression_limit query option on the workload management insert DMLs. If the value of this flag is less than 0, the query option is not set. Otherwise, the query option is set to the value of this new flag. Additionally, the query_log_max_queued startup flag has been reduced from 5,000 to 3,000. This flag places an upper limit on the completed queries queue size, and if workload management attempted to insert 5,000 records at once, it would exceed the 250,000 default for the statement_expression_limit query option. Testing was accomplished by running all workload management related custom cluster tests locally. Change-Id: I999187b33cfab411b62931458f2c4ce3be5ad88d Reviewed-on: http://gerrit.cloudera.org:8080/22652 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/service/workload-management-worker.cc M be/src/workload_mgmt/workload-management-flags.cc M tests/custom_cluster/test_query_log.py 3 files changed, 23 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I999187b33cfab411b62931458f2c4ce3be5ad88d Gerrit-Change-Number: 22652 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
