Michael Smith has uploaded a new patch set (#2) to the change originally created by Jason Fehr. ( http://gerrit.cloudera.org:8080/22652 )
Change subject: IMPALA-13881: Fix Workload Management Statement Expression Limit Exceeded Errors ...................................................................... IMPALA-13881: Fix Workload Management Statement Expression Limit Exceeded Errors The workload management code calculates the needed statement expression limit by multiplying the number of columns in the workload management completed queries table by the number of rows being inserted. This calculation was added in case the default_query_options startup flag sets the default value of the statement_expression_limit query option to a very low value. In practice, the calculation has been wrong causing workload management insert DMLs to fail with: "AnalysisException: Exceeded the statement expression limit (1024)". This commit removes the setting of the statement_expression_limit query option from the workload management code. The default of 250,000 is more than adequate. Additionally, the query_log_max_queued startup flag has been reduced from 5,000 to 3,000. This flag places an upper limit on the completed queries queue size, and if workload management attempted to insert 5,000 records at once, it would exceed the 250,000 default for the statement_expression_limit query option. The test_flush_on_queued_count_exceeded custom cluster test was forcing the default statement_expression_limit query option to 1024 in order to simulate a user performing the same action. That test has been modified to remove the setting of the default query option as the test fails now that workload management no longer hardcodes a value for this query option. Testing was accomplished by running all workload management related custom cluster tests locally. Change-Id: I999187b33cfab411b62931458f2c4ce3be5ad88d --- M be/src/service/workload-management-worker.cc M be/src/workload_mgmt/workload-management-flags.cc M tests/custom_cluster/test_query_log.py 3 files changed, 2 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/22652/2 -- To view, visit http://gerrit.cloudera.org:8080/22652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I999187b33cfab411b62931458f2c4ce3be5ad88d Gerrit-Change-Number: 22652 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
