Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22652 )

Change subject: IMPALA-13881: Fix Workload Management Statement Expression 
Limit Exceeded Errors
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22652/3/be/src/workload_mgmt/workload-management-flags.cc
File be/src/workload_mgmt/workload-management-flags.cc:

http://gerrit.cloudera.org:8080/#/c/22652/3/be/src/workload_mgmt/workload-management-flags.cc@189
PS3, Line 189: uery_log_expression_limit,
> Mention this new flag in commit message.
Done


http://gerrit.cloudera.org:8080/#/c/22652/4/be/src/workload_mgmt/workload-management-flags.cc
File be/src/workload_mgmt/workload-management-flags.cc:

http://gerrit.cloudera.org:8080/#/c/22652/4/be/src/workload_mgmt/workload-management-flags.cc@189
PS4, Line 189: DEFINE_int32_hidden(
> This can be DEFINE_int_hidden, and you can use std::to_string later on. Tre
Done


http://gerrit.cloudera.org:8080/#/c/22652/1/tests/custom_cluster/test_query_log.py
File tests/custom_cluster/test_query_log.py:

http://gerrit.cloudera.org:8080/#/c/22652/1/tests/custom_cluster/test_query_log.py@a300
PS1, Line 300:
             :
> No longer applicable since the workload management insert dml statement_exp
Done



--
To view, visit http://gerrit.cloudera.org:8080/22652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I999187b33cfab411b62931458f2c4ce3be5ad88d
Gerrit-Change-Number: 22652
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 22:35:11 +0000
Gerrit-HasComments: Yes

Reply via email to