Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22106 )
Change subject: IMPALA-13525: Handle escaped characters in string literal ...................................................................... IMPALA-13525: Handle escaped characters in string literal Changed the parser to handle escaped characters. The method is in a new class called ParserUtil. The method was copied from Calcite's SqlParserUtil, but one change was needed. The Calcite method did not handle a backslash in front of a regex character. For Impala, if we detect the backslash in front of a regex character, we leave the character but remove the backslash. This is tested in exprs.test Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685 Reviewed-on: http://gerrit.cloudera.org:8080/22106 Reviewed-by: Aman Sinha <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M java/calcite-planner/src/main/codegen/templates/Parser.jj A java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java 2 files changed, 202 insertions(+), 0 deletions(-) Approvals: Aman Sinha: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685 Gerrit-Change-Number: 22106 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
