Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22106 )
Change subject: IMPALA-13525: Handle escaped characters in string literal ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/22106/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22106/5//COMMIT_MSG@10 PS5, Line 10: ParserUti > nit: The new class name is ParserUtil Done http://gerrit.cloudera.org:8080/#/c/22106/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java: http://gerrit.cloudera.org:8080/#/c/22106/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java@195 PS5, Line 195: > You could use the public static method in SqlParserUtil instead of duplicat I was undecided on this. I kinda like the idea that this class barely had any imports. But I don't mind removing it either. http://gerrit.cloudera.org:8080/#/c/22106/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java@204 PS5, Line 204: > Same as above. Done -- To view, visit http://gerrit.cloudera.org:8080/22106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685 Gerrit-Change-Number: 22106 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 17:19:32 +0000 Gerrit-HasComments: Yes
