Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22106

to look at the new patch set (#6).

Change subject: IMPALA-13525: Handle escaped characters in string literal
......................................................................

IMPALA-13525: Handle escaped characters in string literal

Changed the parser to handle escaped characters. The method
is in a new class called ParserUtil. The method was copied
from Calcite's SqlParserUtil, but one change was needed. The
Calcite method did not handle a backslash in front of a regex
character. For Impala, if we detect the backslash in front of
a regex character, we leave the character but remove the
backslash.  This is tested in exprs.test

Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685
---
M java/calcite-planner/src/main/codegen/templates/Parser.jj
A 
java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java
2 files changed, 202 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/22106/6
--
To view, visit http://gerrit.cloudera.org:8080/22106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685
Gerrit-Change-Number: 22106
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>

Reply via email to