Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py@1949 PS16, Line 1949: self._start_impala_cluster( : options=[ : "--impalad_args=s{}".format(impalad_admission_ctrl_config_args( : fs_allocation_file="fair-scheduler-onlycoords.xml", : llama_site_file="llama-site-onlycoords.xml"))], : add_impalads=True, : cluster_size=6, : num_coordinators=1, : use_exclusive_coordinators=True, : wait_for_backends=False, : workload_mgmt=True) > I initially tried to avoid modifications of start-impala-cluster.py but ran Thanks for checking. I think we should just add new argument for this script to override the final number of expected_cluster_size and expected_num_ready_impalads. impala_cluster.wait_until_ready(expected_cluster_size, expected_num_ready_impalads) If argument is set, ignore whatever the script has calculated before and use the number from argument. Complex test like test_coord_only_pool_add_coord and test_disjiont_clusters should override both number for clarity. -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 17 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 17:12:30 +0000 Gerrit-HasComments: Yes
