Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py@1949 PS16, Line 1949: self._start_impala_cluster( : options=[ : "--impalad_args=s{}".format(impalad_admission_ctrl_config_args( : fs_allocation_file="fair-scheduler-onlycoords.xml", : llama_site_file="llama-site-onlycoords.xml"))], : add_impalads=True, : cluster_size=6, : num_coordinators=1, : use_exclusive_coordinators=True, : wait_for_backends=False, : workload_mgmt=True) > If you revert start-impala-cluster.py, can you rewrite it like this? I initially tried to avoid modifications of start-impala-cluster.py but ran into issues. Using this re-write, the new coordinator starts up but the startup script fails because of: "Waiting for num_known_live_backends=1. Current value: 6". If I then modify cluster_size to be 6, I get this error from the startup script: "AssertionError: Must not start more than 10 impalads". I then attempted to modify the start-impala-cluster.py script to manipulate the 'expected_cluster_size' and 'expected_num_ready_impalads' variables but ran into problems there too. The issue is this test starts a single cluster, and thus the number of expected Impalads (which is a simple count of running Impala processes) matches the expected cluster size. However, test_shared_catalog.py starts one cluster and then re-runs start-impala-cluster.py to spin up a second cluster that shares the catalogd/statestored with the first cluster. In this second run of start-impala-cluster.py, the number of expected Impalads is greater than the expected cluster size since the number of expected Impalads includes processes for both clusters while cluster size includes just the daemons for the second cluster. It's all very confusing and took me awhile to untangle. -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 17 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 16:56:30 +0000 Gerrit-HasComments: Yes
