Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 16: (8 comments) http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/scheduling/cluster-membership-mgr-test.cc File be/src/scheduling/cluster-membership-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/scheduling/cluster-membership-mgr-test.cc@339 PS15, Line 339: ASSERT_EQ(1, cmm1.GetSnapshot()->current_backends.size()); : _assertCoords(cmm1, {"host_1"}); > I would actually prefer to keep the code as is. The reason is that _assert Ack http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/util/webserver.cc@717 PS15, Line 717: LOG(INFO) << "Invalid JWT token provided"; > Why 'bearer_token' is not printed anymore? Nevermind. http://gerrit.cloudera.org:8080/#/c/22249/15/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22249/15/bin/start-impala-cluster.py@1149 PS15, Line 1149: elif options.add_impalads: : cluster_ops.start_impalads(options.num_coordinators, options.num_coordinators, > This has changed because the 'test_coord_only_pool_add_coord' test in test_ Ok, let me reframe my question at test_coord_only_pool_add_coord. http://gerrit.cloudera.org:8080/#/c/22249/15/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22249/15/tests/common/custom_cluster_test_suite.py@417 PS15, Line 417: catalog_log = self.assert_log_contains_multiline("catalogd", "INFO", r'Completed ' : r'workload management initialization.*?A catalog update with \d+ entries is ' : r'assembled\. Catalog version: (\d+)', timeout_s) > This change returns a catalog version that was definitely assembled after w Ack http://gerrit.cloudera.org:8080/#/c/22249/15/tests/common/custom_cluster_test_suite.py@563 PS15, Line 563: : if workload_mgmt: : cmd.append("--impalad_args=--enable_workload_mgmt=true") : cmd.append("--catalogd_args=--enable_workload_mgmt=true") > yes, it's a possibility. I didn't want to muddy this change with other use Ack http://gerrit.cloudera.org:8080/#/c/22249/15/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/15/tests/custom_cluster/test_admission_controller.py@151 PS15, Line 151: > dropping ADMISSIOND_TEST environment variable handling Done http://gerrit.cloudera.org:8080/#/c/22249/15/tests/custom_cluster/test_admission_controller.py@2807 PS15, Line 2807: method.__dict__[START_ARGS] = start_args : if IMPALAD_ARGS in method.__dict__: : method.__dict__[ADMISSIOND_ARGS] = method.__dict__[IMPALAD_ARGS] : super(TestAdmissionControllerStress, self).setup_m > dropping ADMISSIOND_TEST environment variable handling Done http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py@1949 PS16, Line 1949: self._start_impala_cluster( : options=[ : "--impalad_args=s{}".format(impalad_admission_ctrl_config_args( : fs_allocation_file="fair-scheduler-onlycoords.xml", : llama_site_file="llama-site-onlycoords.xml"))], : add_impalads=True, : cluster_size=6, : num_coordinators=1, : use_exclusive_coordinators=True, : wait_for_backends=False, : workload_mgmt=True) If you revert start-impala-cluster.py, can you rewrite it like this? self._start_impala_cluster( options=[ "--impalad_args=s{}".format(impalad_admission_ctrl_config_args( fs_allocation_file="fair-scheduler-onlycoords.xml", llama_site_file="llama-site-onlycoords.xml"))], add_impalads=True, cluster_size=1, num_coordinators=1, use_exclusive_coordinators=True, wait_for_backends=False, workload_mgmt=True) -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 16 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 10 Feb 2025 22:56:20 +0000 Gerrit-HasComments: Yes
