Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 20: (4 comments) Thank you for the review. I have corrected the nits now. http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile-test.cc@1969 PS20, Line 1969: BUCKET_SIZE = 0 > Does this cover the case with json_profile_event_timestamp_limit as 0? Yes. http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile.cc@27 PS20, Line 27: #include <limits> > keep alphabet order Done. http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile.cc@66 PS20, Line 66: json_profile_event_timestamp_limit > what's the range of value? In general, the number of timestamps per event in aggregated profile would be much smaller than this possible range. The range of the value is between 0 and numeric_limits<uint64_t>::max(), to cover the maximum number of timestamps possible. http://gerrit.cloudera.org:8080/#/c/21683/20/be/src/util/runtime-profile.cc@2988 PS20, Line 2988: if(parent->HasMember("info_strings")) { > nit: add a space after "if" Done -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 20 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 04:07:11 +0000 Gerrit-HasComments: Yes
