Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc@2251 PS17, Line 2251: GroupedCase > Ack. I misunderstand the name then. Everything is Grouped, but Aggregation Yeah, that sounds good. I hope the following would be fine. CompleteEvents_GroupedAndUnggregatedCase CompleteEvents_GroupedAndAggregatedCase http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile.cc@67 PS17, Line 67: "Sets the maximum number of instance timestamps to be included within the JSON " : "profile's aggregated event sequence, above which they are bucketed into the set " : "number of aggregates. A value of zero disables aggregation." > But all your implementation is under AggEventSequence::ToJson, and to my kn https://github.com/apache/impala/blame/master/be/src/runtime/coordinator.cc#L242 To be specific, all aggregated profiles are included in JSON profile as "Averaged Profile". It was actually part of IMPALA-9382: part 1: transposed profile prototype Initially, even I had thought that aggregated profiles are not generated otherwise. Please let me know, if I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 17 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 06:08:06 +0000 Gerrit-HasComments: Yes
