Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 19: (2 comments) Great work! Please go ahead and address the remaining nits. I have no further comment. Lets find another +1 from other reviewer. Then I can give my +2. http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc@2251 PS17, Line 2251: > Yeah, that sounds good. I hope the following would be fine. Sounds good to me. http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile.cc@67 PS17, Line 67: "Sets the number of spans / buckets for grouping of event timestamps within" : " the aggregated JSON profile. For example, if the number of fragment" : " instances(N) reporting an event is more than(N > M) the set > https://github.com/apache/impala/blame/master/be/src/runtime/coordinator.cc You are actually right. I have forgot how it was implemented. https://github.com/apache/impala/commit/79b17db83a2f97a409e468c5dd5cfaeb9454f5dd#diff-ce35f5debfcd78e459df644252db7748d135cec85407f296f4ab5662f42d1e1dR437 -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 19 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 06:41:56 +0000 Gerrit-HasComments: Yes
