Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 47: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@90 PS45, Line 90: // Whether the token is an "unreserved keyword". > Thanks! Added. Ack http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@342 PS45, Line 342: KW_ORC, KW_ORDER, KW_OUTER, > In the previous patch sets, KW_QUERY was not added in alphabetical order. Ack http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@3576 PS45, Line 3576: | KW_CLUSTERED : {: RESULT = new PlanHint("clustered"); :} : | ident_or_unreserved:name : {: RESULT = new PlanHint(name); :} : | ident_or_unreserved:name LPAREN ident_list:arg > Thanks! Changed. Done http://gerrit.cloudera.org:8080/#/c/21930/45/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/21930/45/tests/util/cancel_util.py@127 PS45, Line 127: _state > Done Ah, you use create_connection rather than create_impala_client because this is a helper class without access to ImpalaTestSuite? I guess having to call "connect" after isn't a big hassle. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 47 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 21:10:29 +0000 Gerrit-HasComments: Yes
