Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22285 )
Change subject: IMPALA-12993: Encrypt password in JDBC table properties when saving into HMS DB ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@69 PS3, Line 69: secretKey = keyGen.generateKey(); This is generating a key on startup. If instance is restarted, we'll get a new key and be unable to read any encrypted data. -- To view, visit http://gerrit.cloudera.org:8080/22285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4189f4d83377f3c780f6c246f78eb46b46af9305 Gerrit-Change-Number: 22285 Gerrit-PatchSet: 3 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2025 19:33:53 +0000 Gerrit-HasComments: Yes
