Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22285 )
Change subject: IMPALA-12993: Encrypt password in JDBC table properties when saving into HMS DB ...................................................................... Patch Set 3: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@64 PS3, Line 64: secretKey = new javax.crypto.spec.SecretKeySpec(decodedKey, 0, decodedKey.length, "AES"); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4189f4d83377f3c780f6c246f78eb46b46af9305 Gerrit-Change-Number: 22285 Gerrit-PatchSet: 3 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2025 05:12:32 +0000 Gerrit-HasComments: Yes
