Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22285 )
Change subject: IMPALA-12993: Encrypt password in JDBC table properties when saving into HMS DB ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@69 PS3, Line 69: keyGen.init(256); > We’re not generating a key while decrypting, whenever we’re encrypting we’r Oh, this is pretty much purely to obfuscate it when the password might be displayed to users? That was not at all clear from the commit message. -- To view, visit http://gerrit.cloudera.org:8080/22285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4189f4d83377f3c780f6c246f78eb46b46af9305 Gerrit-Change-Number: 22285 Gerrit-PatchSet: 6 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2025 21:03:37 +0000 Gerrit-HasComments: Yes
