Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/21955/26/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/26/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@459 PS26, Line 459: for (TupleId tupleId : pNode.tupleIds_) { : producerNodes.putIfAbsent(tupleId, pNode); > nit: multi-line statements should have brackets Done http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test File testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test: http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test@a1157 PS26, Line 1157: > This testcase was moved to aggregation.test by IMPALA-13480. Apparently, wi Done -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 27 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 18:12:53 +0000 Gerrit-HasComments: Yes
