Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test File testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test: http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test@a1157 PS26, Line 1157: > Could you comment on why this test was removed ? It was introduced in IMPA This testcase was moved to aggregation.test by IMPALA-13480. Apparently, with patches get shifted around few days back, I forgot to drop this copy. https://gerrit.cloudera.org/c/22184/ Will update the commit message. http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q31.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q31.test: http://gerrit.cloudera.org:8080/#/c/21955/26/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q31.test@83 PS26, Line 83: | | tuple-ids=28 row-size=50B cardinality=1.43M cost=299319961 > Any idea why the cost of this operator did not change even though the cardi Thanks for noticing this. It looks like the costing algorithm still use old multiplication-based NDV estimation from PlanFragment.getPerInstanceNdvForCpuCosting(). It intended to incorporate the same idea from IMPALA-2945. Coincidentally, I reimplement the same preagg logic too in https://gerrit.cloudera.org/c/22047/ I will investigate how to reconcile the logic, before merging this patch. -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 26 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 00:05:32 +0000 Gerrit-HasComments: Yes
