Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 )
Change subject: IMPALA-13551: Produce the shell tarball by pip installing impala-shell ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20171/8/shell/.gitignore File shell/.gitignore: http://gerrit.cloudera.org:8080/#/c/20171/8/shell/.gitignore@3 PS8, Line 3: /ext-py/ > Is anything expected to add to ext-py? Not sure why we ignore it. I think it is more about having "git clean -Xdf" remove ext-py after a rebase. This isn't really needed because ext-py no longer has any impact on the build. I'm fine either way on this. http://gerrit.cloudera.org:8080/#/c/20171/8/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/20171/8/shell/make_shell_tarball.sh@66 PS8, Line 66: --build ${BUILD_TMP_DIR} ${PYPI_PACKAGE} > With Yeah, I need to test on more distributions. The --build flag may not be needed. I'm running tests on redhat8, centos7, sles15. I'll try to run more. -- To view, visit http://gerrit.cloudera.org:8080/20171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb66ab2c5bc7180221f98d9bf5e38d62f4ac036 Gerrit-Change-Number: 20171 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2024 19:37:35 +0000 Gerrit-HasComments: Yes
