Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 )
Change subject: IMPALA-13551: Produce the shell tarball by pip installing impala-shell ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG@16 PS7, Line 16: impala-shell-4.5.0-SNAPSHOT/ : impala-shell : install_py${PYTHON_VERSION}/ > My intention is to describe the directory structure of the shell tarball it Done http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt@70 PS7, Line 70: add_custom_target(shell_impala_build_version : DEPENDS gen-deps "${CMAKE_SOURCE_DIR}/bin/version.info" : COMMAND "${CMAKE_SOURCE_DIR}/shell/gen_impala_build_version.sh" : ) > This is an existing problem. Our Thrift code generation doesn't understand Ack I think removing all generated files inside be/generated-sources/gen-cpp/ and then run "make gen-deps" can solve it. -- To view, visit http://gerrit.cloudera.org:8080/20171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb66ab2c5bc7180221f98d9bf5e38d62f4ac036 Gerrit-Change-Number: 20171 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 01:38:26 +0000 Gerrit-HasComments: Yes
