Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 )
Change subject: IMPALA-13551: Produce the shell tarball by pip installing impala-shell ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20171/7//COMMIT_MSG@16 PS7, Line 16: impala-shell-4.3.0-SNAPSHOT/impala-shell : /install_py${PYTHON_VERSION} : /install_py${ANOTHER_PYTHON_VERSION} I think it looks better this way $IMPALA_HOME/ shell/ build/ impala-shell-4.3.0-SNAPSHOT/ impala-shell install_py${PYTHON_VERSION} install_py${ANOTHER_PYTHON_VERSION} http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20171/7/shell/CMakeLists.txt@70 PS7, Line 70: add_custom_target(shell_impala_build_version : DEPENDS gen-deps "${CMAKE_SOURCE_DIR}/bin/version.info" : COMMAND "${CMAKE_SOURCE_DIR}/shell/gen_impala_build_version.sh" : ) "make shell_impala_build_version" does not work if I remove shell/gen-py. ./gen_impala_build_version.sh: line 47: /home/rsuminto/workspace/impala/shell/gen-py/impala_build_version.py: No such file or directory ERROR in ./gen_impala_build_version.sh at line 47: cat > ${THRIFT_GEN_PY_DIR}/impala_build_version.py <<EOF Why shell/gen-py is not rebuild? "make shell_tarball" also does not work. What command should I run to fully rebuild shell? -- To view, visit http://gerrit.cloudera.org:8080/20171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb66ab2c5bc7180221f98d9bf5e38d62f4ac036 Gerrit-Change-Number: 20171 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2024 23:27:05 +0000 Gerrit-HasComments: Yes
