Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21805 )

Change subject: IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java
......................................................................


Patch Set 7:

(3 comments)

> Uploaded patch set 7.

http://gerrit.cloudera.org:8080/#/c/21805/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21805/6//COMMIT_MSG@23
PS6, Line 23: pushd fe && mvn -fae test -Dtest=JdbcDataSourceTest
> The individual test case could be ran with mvn, for example
Done


http://gerrit.cloudera.org:8080/#/c/21805/6/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java
File 
fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java:

http://gerrit.cloudera.org:8080/#/c/21805/6/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@95
PS6, Line 95:
> The unit test cases in this class have dependency. They must be ran sequent
Done


http://gerrit.cloudera.org:8080/#/c/21805/6/java/ext-data-source/jdbc/pom.xml
File java/ext-data-source/jdbc/pom.xml:

http://gerrit.cloudera.org:8080/#/c/21805/6/java/ext-data-source/jdbc/pom.xml@36
PS6, Line 36: properties>
> Do we need to make this change and the one below? The test source file is m
Done



--
To view, visit http://gerrit.cloudera.org:8080/21805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127
Gerrit-Change-Number: 21805
Gerrit-PatchSet: 7
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 12 Dec 2024 05:22:53 +0000
Gerrit-HasComments: Yes

Reply via email to