Pranav Lodha has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/21805 )
Change subject: IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java The unit test `JdbcDataSourceTest.java` was originally implemented using the H2 database, which is no longer available in Impala's environment. The test code was also outdated and erroneous. This commit addresses and fixes the failure of JdbcDataSourceTest.java and rewrites it in Postgres, hence ensures compatibility with Impala's current environment and aligns with JDBC and external data source APIs. Please note, this test is moved to fe folder to fix the BackendConfig instance not initialized error. To test this file, run the following command: pushd fe && mvn -fae test -Dtest=JdbcDataSourceTest Please note that the tests in JdbcDataSourceTest have a dependency on previous tests and individual tests cannot be ran separately for this class. Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 --- R fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java M java/ext-data-source/jdbc/pom.xml D java/ext-data-source/jdbc/src/test/resources/test_script.sql M testdata/bin/create-ext-data-source-table.sql M testdata/bin/load-ext-data-sources.sh 5 files changed, 87 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/21805/7 -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 7 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
