Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 6: (2 comments) > Uploaded patch set 6. http://gerrit.cloudera.org:8080/#/c/21805/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21805/5//COMMIT_MSG@23 PS5, Line 23: hd fe && mvn -fae test -Dtest=JdbcDataSourceTest : > Can run test in one step as Done http://gerrit.cloudera.org:8080/#/c/21805/5/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java File fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java: http://gerrit.cloudera.org:8080/#/c/21805/5/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@60 PS5, Line 60: @BeforeClass : public static void setup() { : // The original BackendConfig need to be mocked, we are saving the values here, so : // they can be restored and not break other tests : if (BackendConfig.INSTANCE == null) { : BackendConfig.create(new TBackendGflags()); : } : origFlags = BackendConfig.INSTANCE.getBackendCfg(); : } > Please correct indentations for this function, and other functions and vari Done -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 6 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2024 16:34:18 +0000 Gerrit-HasComments: Yes
